Support waveform alignment (top, bottom, middle)

[RJ Skerry-Ryan]

Should allow the skin to make waveforms overlapped.

[Daniel Lindenfelser (dan-lin)]

http://djnillin.de/VWaveforms.png with qml skins this is one line of code

rotation: 90

[toomuch (toomuch)]

I would prefer overlapping waveforms. Then you would see exactly when beats are correct or need adjustment.

[RJ Skerry-Ryan (rryan)]

overlapping / vertical choice is up to the skin designer, but the widgets
need the code to actually support those modes

On Tue, Jan 10, 2012 at 10:36 AM, toomuch <email address hidden> wrote:

> I would prefer overlapping waveforms. Then you would see exactly when
> beats are correct or need adjustment.
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/661442
>
> Title:
> Vertical or Overlapped Waveforms
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/661442/+subscriptions
>

[Thomas Vincent (vrince)]

I can easily add overlapping in waveform-2.0 but for vertical it's gonna be an other story ...
I need to a pixel buffer in the OpenGl one and the pure-Qt one need a rework to be efficient.
Good new for the GLSL one, it only require switching some texture attributes :) !

[toomuch (toomuch)]

Hey Thomas, I would be glad to see overlapping waveforms in the LateNight skin. I think vertical waveforms should have a separate thread as it harder to implement. Does anyone know how to customize the LateNight skin to have overlapping waveforms or knows the skin designer so that I could contact him?

[Thomas Vincent (vrince)]

Ok so for the overlap version it's gonna be i the next 1.11 release I think.
I implemented it and modified one version of the LateNight skin (1200x800) to test it out.

Some small changes have to be performed on all skins to take advantage of the new waveform features (including overlapping/alignment of the waveform signal).

[Thomas Vincent (vrince)]

I created a new bug for the "vertical" part of this one
https://bugs.launchpad.net/mixxx/+bug/975203

[toomuch (toomuch)]

Thanks for your efforts. :) Happy Easter!

[Nanovarium (nanovarium)]

I As far as I understand it is now possible to view overlapping waveforms?

If not, Thinking of this topic:

http://www.mixxx.org/forums/viewtopic.php?f=8&t=2018&p=7667&hilit=waveform#p7667

it should be possible to use a fully sized waveform and just overlay the top/bottom half to "make it look like" they are overlapping.

So cut off the top of the upper waveform with a mask and vice versa.

[toomuch (toomuch)]

Does anybody know when 1.11 will be ready to download? Is the "Expected Date" (2012-06-30) in the milestone description still valid? Unfortunately, the Mixxx Development Blog is updated just from time to time...

[toomuch (toomuch)]

Hi Thomas, I just tested the alpha2 build r3248 from today. How do I get overlapped waveforms working?

[Thomas Vincent (vrince)]

In skins set waveform alignment to 'top' or 'bottom'.
Something like
<Visual>
    ...
    <Align>top</Align>
    ...
</Visual>
Not so sure about case of tags and values (if it does not work try 'Top' ...).
Regarding which way you aligned signals you may need to set cues alignment too.
T

2012/6/7 toomuch <email address hidden>:
> Hi Thomas, I just tested the alpha2 build r3248 from today. How do I get
> overlapped waveforms working?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/661442
>
> Title:
>  Overlapped Waveforms
>
> Status in Mixxx:
>  Fix Committed
>
> Bug description:
>  Should allow the skin to make waveforms overlapped.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/661442/+subscriptions

[toomuch (toomuch)]

Thanks for the quick reply.

After playing with the align value for quiet some time with no success I looked at the manual for creating skins: http://www.mixxx.org/wiki/doku.php/creating_skins. I wondered about the <DefaultMark> section where the align tag was included. I took the align tag out of that section and put it into the parent section.

The result are not two overlapping waveforms but something close:
<a href="http://www.imagebanana.com/view/uqqxms8h/waveforms.jpg"><img src="http://img6.imagebanana.com/img/uqqxms8h/thumb/waveforms.jpg" border="0" alt="www.ImageBanana.com - waveforms.jpg" /></a>

[Thomas Vincent (vrince)]

Yeah overlapping occurs between left/right channel of a track not
between two tracks ... sorry for the confusion around the word
overlapping.

Regarding the Default mark, it was implemented lately too
automatically create hot cue display with a default style when no
explicit <Mark> element is provided.
It`s mostly useful for hot cue from 5 to 36, in most case skin do no
differentiate it anyway.

My English is not so good but I`ll try to find 10 minutes to add
something about that in the wiki page !

T

2012/6/7 toomuch <email address hidden>:
> Thanks for the quick reply.
>
> After playing with the align value for quiet some time with no success I
> looked at the manual for creating skins:
> http://www.mixxx.org/wiki/doku.php/creating_skins. I wondered about the
> <DefaultMark> section where the align tag was included. I took the align
> tag out of that section and put it into the parent section.
>
> The result are not two overlapping waveforms but something close:
> <a href="http://www.imagebanana.com/view/uqqxms8h/waveforms.jpg"><img src="http://img6.imagebanana.com/img/uqqxms8h/thumb/waveforms.jpg" border="0" alt="www.ImageBanana.com - waveforms.jpg" /></a>
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/661442
>
> Title:
>  Overlapped Waveforms
>
> Status in Mixxx:
>  Fix Committed
>
> Bug description:
>  Should allow the skin to make waveforms overlapped.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/661442/+subscriptions

[RJ Skerry-Ryan (rryan)]

I've filed Bug #1015711 to track the other request (overlapping the waveforms of multiple tracks)

[toomuch (toomuch)]

Just asking: Is this (#1015711) really wanted? I can live perfectly with the solution provided above.

[RJ Skerry-Ryan (rryan)]

I'm not sure. I think it might be a way to save screen real estate. I think that the important part of Bug #1015711 is that we can put multiple waveforms in the same GL widget. Qt has performance issues with many GL widgets on the screen at once so it would be a benefit to support combining waveforms into one widget even if they are not overlapping each other.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5568