Comment 3 for bug 637488

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Nice catch on the lack of deletion of the tracksToAdd. Oops!

Albert and I agree that skipping the art folder is probably never going to get us into trouble.

In the future, if we have even more files to blacklist, we may want to switch to a QSet of QStrings for checking if things are on the blacklist. For one test I think its probably slightly faster to just compare it to the art folder path, since it can early-exit if the two strings are of unequal length (Qt does this in its QString implementation, I checked).

Thanks!