Holding Cue then pressing Play should continue track playback

Reported by Sean M. Pappalardo on 2008-12-19
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Mixxx
Wishlist
Qifan Xi

Bug Description

With cueing in CDJ mode, holding CUE plays the track from the cue point as long as the button is held down. If you then press PLAY (momentarily pressing both) to continue playback so you don't have to hold anything down, the track pauses.

Suggestion: Holding CUE currently seems to set an internal Play flag as long as it's held down. Is it possible to instead play the track without setting that flag (i.e. while Mixxx still thinks it's paused?) That way, as long as the PLAY button takes precedence over CUE, pressing PLAY later will activate the Play flag and it should work as requested.

Related branches

ironstorm (ironstorm-gmail) wrote :

Albert and I brainstormed about how to fix this a month or so back and came up with an idea... Not sure it was implemented or not.

Changed in mixxx:
assignee: nobody → gamegod

Yeah, the solution we conjured up is still sitting in Mixxx docs.
Pasting here for convenience:

============
(changes to make inside enginebuffercue.cpp)

You hold cue:
- Sets ControlObject play to 1.

You hit play:
- You check to see if cue is down.
   - If cue is down and play is hit, then set CuePlay to 1.
     - and drop the "play = 0" event.

Next, when cue is released:
- You check if CuePlay is 1, and if so, then set CuePlay to 0 and drop
   the "stop playback" event.
=============

Before we figured out this simplified logic, I took a crack at it and
failed. This isn't a super high priority for me right now though. :)

Albert

On Fri, Dec 19, 2008 at 9:35 AM, ironstorm <email address hidden> wrote:
> Albert and I brainstormed about how to fix this a month or so back and
> came up with an idea... Not sure it was implemented or not.
>
> ** Changed in: mixxx
> Assignee: (unassigned) => Albert Santoni (gamegod)
>
> --
> Holding Cue then pressing Play should continue track playback
> https://bugs.launchpad.net/bugs/309722
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

ironstorm (ironstorm-gmail) wrote :

Just to clarify the
 drop the "play = 0" event

This is actually a play = !play type toggle. Since the CO.Play is 1 from holding Cue, hitting Play again would do CO.Play = 0, but we drop that update in favour of toggling CO.CuePlay instead Cue is also down.

Changed in mixxx:
importance: Undecided → Low
status: New → Triaged
milestone: none → 1.6.3

This can be worked around in MIDI script until it's fixed in the engine. See the SCS.3d script's .play and .cue functions for an example of how.

Changed in mixxx:
milestone: 1.8.0-moving → 1.8.0
RJ Ryan (rryan) wrote :

This doesn't show signs of getting fixed for 1.8.0. Getting it off the bug page.

Changed in mixxx:
milestone: 1.8.0 → 1.8.1
RJ Ryan (rryan) on 2010-10-18
Changed in mixxx:
milestone: 1.8.1 → 1.8.2
RJ Ryan (rryan) on 2010-10-20
Changed in mixxx:
importance: Low → Wishlist
milestone: 1.8.2 → none
Qifan Xi (khyew) wrote :

Committed working fix for both the cue button and hotcues in dev branch lp:~khyew/mixxx/khyew-dev

Changed in mixxx:
assignee: Albert Santoni (gamegod) → Qifan Xi (khyew)
milestone: none → 1.10.0
status: Triaged → In Progress
jus (jus) wrote :

Great!
It would be even greater if this would also work with Hotcues (think consistency).

Currently if a player is stopped and a Hotcue button is pressed the playback continues from this Hotcue as long as the Hotcue button is pressed.

Pressing the Play button while the Hotcue button is pressed should continue the playback even if the Hotcue button is lifted.
Just like the committed change for the "normal" Cue button.

Qifan Xi (khyew) wrote :

My fix applies to the hotcues as well.

jus (jus) wrote :

Thanks Qifan Xi for the clarification, should have read comment #6 more precisely ;-)

Albert Santoni (gamegod) wrote :

Fix has been committed to the 1.9 branch. Thanks for resolving this long-standing bug Qifan!

Changed in mixxx:
status: In Progress → Fix Committed
milestone: 1.10.0 → 1.9.1
RJ Ryan (rryan) on 2011-11-07
Changed in mixxx:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers