Comment 2 for bug 1980264

Revision history for this message
Nicolas MURE (nm2107) wrote :

Just to confirm that commenting the `return` statement in this code block fixes my issue :

https://github.com/mixxxdj/mixxx/blob/2.3.3/src/engine/enginebuffer.cpp#L1260-L1270

However, commenting only the `m_filepos_play == kInitialSamplePosition` part of the condition doesn't fixes the issue.

I understand the `m_trackSampleRateOld == 0` and `m_tempo_ratio_old == 0` checks to prevent division by `0` (operated a few lines later), but why is the `m_filepos_play == kInitialSamplePosition` check for ? And also, why am I entering the condition body ? Only because the DVS signal is quiet (i.e. I am on a CUE point) ? Shouldn't we perform an other check to determine whether we're playing instead of relying on the `tempo_ratio` ?