Comment 8 for bug 1928772

Revision history for this message
ronso0 (ronso0) wrote : Re: waveform not scrolling on macOS

This is kind of being wokred around already since the default waveform renderers are not affected, and when Mixxx crashes during skin because an affected renderer is selected that wouldn't be stored in the config, so it can at least be restarted without issues.

First I thought that might be caused by waveforms being loaded in Singletons, but that's not the case for affected LateNight (and not necessary in Tango btw).
Then we had Deere previously crashing on macOS if spinnies and waveforms were in the same singleton. But that's also been changed.
Back then, one conclusion was that reparenting the singleton caused issues with the GL context.

So it seems skins are affected as soon as ANY GL widget is loaded into a Singleton.
Solution would be to load individual instances of spinnies and waveforms in every skin, but that would defeat the purpose of saving memory only for getting the simple renderer to work on macOS.

Given the fact (assumption?) that the computers running the minimum supported macOS version 10.12 are powerful enough to not require the simple renderers for performance reasons we can simply hide them on macOS -- and switch to another renderer in case a simple renderer is stored in the config after upgrading to 2.3.

What do you think?