Mixxx

  1. Bug #1856888
  2. Comment #6

Comment 6 for bug 1856888

Revision history for this message
Foss-4 (foss-4) wrote : Re: seg fault crash when switching theme with RGB (GLSL) waveform renderer selected, also crashing when switching to RGB (GL)

Findings from duplicate report:

Jean-Michaël:
I've tried changing skin on current master (mac mini 2018, 10.14, Qt 5.15 from homebrew) but I don't seem to hit the issue.
I however seem to hit the same backtracewhen quitting Mixxx so that may be related ?
It seems to be due to

GLSLWaveformWidget::~GLSLWaveformWidget() {
    makeCurrent();
}

^ I don't really know Mixxx's architecture, but that seems quite dangerous if the SharedGLContext::getWidget()'s context gets destroyed before the waveform widget - maybe some place in the code should introduce an explicit ordering of child widget deletion in a destructor that guarantees that the waveforms are deleted first, before the main window is closed, instead of relying on Qt's parent-child automatic destruction for this case.

Uwe:
The invocation of makeCurrent() also triggers a crash on Linux when closing Mixxx with Alt+F4:
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/shutdown.20crash

https://github.com/mixxxdj/mixxx/pull/2933