Comment 6 for bug 1748001

Revision history for this message
Benis (beenisss) wrote :

It kinda depends what was in mind when the skins/key control code was written.

Basically, the key reset action resets the pitchRatio value to 1.0. On the Shade skin you can do this by right-clicking the coarse-adjust key slider, or by right-clicking Sync Key to reset it. However (and this is true for all skins) reset using the Sync Key button only works if the track has a key set. I don't know if this is intentional or not - I can sort of see the justification for it working this way, but given that you can reset the pitchRatio value without a track key being present (and the effect is identical with or without), it's kind of a pain that the button action only works for tracks with a key, when none of the other skins have a key slider.

The reason I originally raised this issue is that almost none of my tracks have key information and this makes it difficult to use reset. I actually want the reset behaviour to do something different (reset pitchTweakRatio to 1.0 rather than resetting pitchRatio) but I figured this issue (if it's considered valid) should be dealt with first.

There's also been some discussion on this in the key manipulation stream on Zulip:
https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/Key.20manipulation

As a side note, the response areas for manipulating the key sliders on Shade aren't aligned properly - in the attached screenshot the white boxes indicate the area where the skin responds to a click and drag action. Obviously this should be a few pixels lower in each case (which matters as the sliders are tiny.) I will have a look at this at some point if somebody else doesn't get to it first.