improve UX for switching skins

[Daniel Schürmann]

We have changed recently that the skin change happens only after apply or OK.

I think we should revert this change, because we have no skin preview yet.
The old behaviour was a kind workaround for this.

Currently there is the other issue that the options dialog freezes after pressing OK with no responds.
This gives the impression Mixxx is broken.

We had this issue before, but it happens directly after strong related change of the skin, which was never an issue for me.

Whe can reintroduce the current behaviour after
https://bugs.launchpad.net/mixxx/+bug/997278
is merged.

What do you think?

[jus (jus)]

Agree, the current way of handling this is odd.
+1 for Skin-picker in v2.20

[ronso0 (ronso0)]

Goes hand in hand with lp:1741290 ;)

[ronso0 (ronso0)]

Whoopsy! Comment should go to lp:997278

[Be (be.ing)]

I don't think we should revert the change to not apply changed settings without clicking the Apply button. I think adding a preview screenshot for each skin would be a good solution to this. That would be a pretty small and straightforward change, so if you feel that the current behavior is really annoying then I'd be okay with merging that for 2.1.

[Daniel Schürmann (daschuer)]

Since this is a kind of regression from 2.0, we should first revert this and immediately apply the skin change.
If you can effort the time to prepare a skin picker solution we it is also nice.
I think we can decide along the existing PR, if it suits to break feature freeze for it, or if we should better merge it to master.
For me, only going back to the 2.0 state already works.

[Be (be.ing)]

I can take care of this and Bug #1745679 for 2.1, but I do not think I will have time to work on it immediately. Finishing the manual is a higher priority for me.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9110