Comment 5 for bug 1653631

Greate. IMHO your use-case is valid and would be a nice addition as a
separate mode. The only question is how to add it reasonable to the
existing code, an visualise in the GUI.

Am 06.01.2017 3:30 nachm. schrieb "ronso0" <email address hidden>:

> Okay, I will have a look at the code and the conversation and see if I
> can do something at all.
>
> > One argument for the current behavior was that it should be possible
> > to return to the original key without any pain. This is quired to go
> > back to clean sound and save a lot CPU.
> I see.
>
> > An other issue was that the key knob should not turn when enabling and
> > disabling key lock.
> Okay. So my wish would help since now it jumps when unlocking, wouldn't it?
>
> > Maybe we need an additional control for your mode.
> I imagine the new feature being a checkbox below "Lock Original Key" and
> "Lock current key" with a label like this:
> "[ ] when unlocking, keep locked key until next rate change"
> When changing rate afterwards, formerly locked key would be base for any
> key change, no jumps.
>
> > Do you have experiences with other tools or player?
> Nope, none. Just innocent expectations...
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1653631
>
> Title:
> unexpected keylock release behaviour
>
> Status in Mixxx:
> New
>
> Bug description:
> I explain what I'd expect:
> * a track is playing with a rate of +5%, original key is locked
> * releasing keylock should keep that locked key (original or not), but:
> * from now on, any change of rate would change key as well
> * use jogwheels to simulate an old, worn out cassette or to add
> 'accents' to instrumentals, which is fun and -when used rarely- really can
> spice up a mix!
>
> That's a scenario currently not covered by "Lock current key" or "Lock
> original key" setting:
> Right now, when releasing keylock while rate is above or below original,
> key jumps to that newly calculated key and thus sounds odd.
>
> Could someone point me to where this lock/unlock is done in source?
> I can't say if this SHOULD be covered by current settings or if a third
> option could handle this.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1653631/+subscriptions
>