Comment 2 for bug 1607277

Revision history for this message
Daniel Schürmann (daschuer) wrote :

I probably do not understand the issue. Here is what I have got:

> I connected [EffectRack1_EffectUnit1],group_[Channel1]_enable to a led in XML.

This should work as usual. The LED should always reflect the "[ Ch1 ]" button in the LateNight skin. Is this true on your side?

> then, after some change in the led states, in javascript, trying
> engine.trigger("[EffectRack1_EffectUnit1]","group_[Channel1]_enable");
> to update the leds doesn't have any effect, the leds are not updated.

https://github.com/mixxxdj/mixxx/blob/7c58008d3ff35026763fdf7198905b068435e07e/src/controllers/controllerengine.cpp#L696

This should transmit the current state of the CO to the LED. It should be not required unless there is an another instance which is controlling the LED.
But anyway, after this, the LED and the GUI button should be in synch. Is this true on your side?

> is it possible to update leds from javascript engine.trigger when the led are connected in XML ?

If you uses engine.trigger("[EffectRack1_EffectUnit1]","group_[Channel1]_enable", value), both the mapped controller LED and the GUI LED should be updated. If this is not the case, it is a bug. Does it happen?