Cancelling cover art scan doesn't actually stop it

[Sean M. Pappalardo]

Canceling a library scan in the cover art stage doesn't actually stop the scan until Mixxx is closed. (The dialog box goes away though.)

Is this by design?

Happens in 2.0 branch as of commit 5c244910e7a2588a8533acc8e79ca2792b0324ab

[RJ Skerry-Ryan (rryan)]

Yes -- its not currently cancelable iirc. I left that as a to-do

On Tue, Dec 1, 2015, 4:45 PM Sean M. Pappalardo <email address hidden>
wrote:

> Public bug reported:
>
> Canceling a library scan in the cover art stage doesn't actually stop
> the scan until Mixxx is closed. (The dialog box goes away though.)
>
> Is this by design?
>
> Happens in 2.0 branch as of commit
> 5c244910e7a2588a8533acc8e79ca2792b0324ab
>
> ** Affects: mixxx
> Importance: Low
> Status: New
>
>
> ** Tags: library
>
> ** Description changed:
>
> Canceling a library scan in the cover art stage doesn't actually stop
> the scan until Mixxx is closed. (The dialog box goes away though.)
>
> Is this by design?
> +
> + Happens in 2.0 branch as of commit
> + 5c244910e7a2588a8533acc8e79ca2792b0324ab
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1521796
>
> Title:
> Cancelling cover art scan doesn't actually stop it
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1521796/+subscriptions
>

[Sean M. Pappalardo (pegasus-renegadetech)]

So that's a Confirm then. Can this be done for 2.0.0 or do we target it for 2.0.1?

[RJ Skerry-Ryan (rryan)]

yea, unless I'm misremembering -- 2.0.1

[Daniel Schürmann (daschuer)]

We will release 2.1 within three month after 2.0.0.
We should avoid a 2.0.1 release, unless we experience a relay annoying issue, which requires an urgent quick fix.
We have already collected a bunch of fixes annoying decoding issues in 2.1, which matters a lot.
IMHO this is not a bug of that type.
Can we move it to 2.1? Same question rises for Bug #1522507.

Any thoughts?

[Sean M. Pappalardo (pegasus-renegadetech)]

Oh, I'm just targeting bugs based on if they can feasibly be done in the 2.0 branch or not. Of course we will include all 2.0.x bug fixes in a 2.1 release anyway.

[Owen Williams (ywwg)]

Yeah I agree, in general I don't want to be doing backports to 2.0, so unless something is a major blocker I'd prefer to push it to 2.1. Are there situations where a user on a slow machine with a huge library is not going to be able to use Mixxx because the cover scan takes so long? If so, then maybe it's worth fixing now, before the release.

[Sean M. Pappalardo (pegasus-renegadetech)]

It seems that the cover art scan runs at lower priority (at least the analyzer and stuff still responds as expected while the cover art is being scanned,) so it's not a big deal. Users may just wonder why all the disk activity. (What are the chances of the Engine threads getting starved for audio data if the disk is pinned?)

[RJ Skerry-Ryan (rryan)]

If the thread priorities work correctly (i.e. not on most OOTB Linux
distros :P) and there are no priority inversions in our codebase then it's
unlikely to affect the engine.

On Tue, Dec 8, 2015 at 7:59 PM, Sean M. Pappalardo <
<email address hidden>> wrote:

> It seems that the cover art scan runs at lower priority (at least the
> analyzer and stuff still responds as expected while the cover art is
> being scanned,) so it's not a big deal. Users may just wonder why all
> the disk activity. (What are the chances of the Engine threads getting
> starved for audio data if the disk is pinned?)
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1521796
>
> Title:
> Cancelling cover art scan doesn't actually stop it
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1521796/+subscriptions
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8350