Comment 20 for bug 1514335

On mobile, but I'm pretty sure fromUcs4/fromUtf16 don't do null checks if
you provide a length. (Ie they decode exactly that many wide or single
width characters -- even if they are garbage memory.

wcsncpy has different semantics -- copy up to the null but no more than the
safety length then we insert a null at the end in case of faulty devices
that didn't null terminate their strings.

On Tue, Nov 17, 2015, 6:15 PM RJ Ryan <email address hidden> wrote:

> Could folks try reverting this commit:
>
> https://github.com/mixxxdj/mixxx/commit/344ae07a8ab8ed2058de6bb9be910286212f2170
>
> I don't think we should remove /Zc:wchar_t-. Qt is built with
> /Zc:wchar_t- on Windows and we want to build Mixxx with the same options
> that Qt uses. Daniel, could you explain why this was needed?
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1514335
>
> Title:
> detected HID devices shown in preference with random characters in
> Mixxx 1.12
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1514335/+subscriptions
>