Playback of M4A files on Windows through SoundSourceMediaFoundation plugin is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Critical
|
Unassigned |
Bug Description
[master]
The tests for sample accurate seeking of M4A files in SoundSourceProx
Furthermore reading of sample data sometimes seems to result in more samples than have actually been requested. This is dangerous, because it might write data outside the bounds of the buffer that is allocated by the caller!
*TODO*
* Determine the exact length of the audio stream in frames/samples and set by invoking setFrameCount(). Currently this is an approximate value calculated from the duration.
* Fix seeking and decoding in SoundSourceMedi
* Remove #ifndef __WINDOWS__ // TODO(XXX) from soundproxy_test.cpp and re-add ".m4a" to availableFileNa
* No more violations of DEBUG_ASSERTs in the caller's code, e.g. AnalyserQueue
description: | updated |
description: | updated |
description: | updated |
Changed in mixxx: | |
status: | In Progress → Fix Committed |
Changed in mixxx: | |
milestone: | none → 2.1.0 |
Changed in mixxx: | |
importance: | Undecided → Critical |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
I neither have the time to fix this issue nor do I have a native Windows dev. environment (only a slow VM). But I'm happy support anyone who is willing to take responsibility for this task.
For an example on how to do the buffering of decoded sample data in the "leftover" buffer please have a look at SoundSourceFLAC and SoundSourceM4A.