Comment 5 for bug 1481170

In many cases I think Daniel's suggestion is ok, waiting for a settled case and then disabling. However, some effects, like a distortion processor, produce sound even with no input -- there's a constant hum of the distorter being active. It has to be up to the user to fade from wet to dry themselves and disable it manually.

In general toggling the on/off state of the effect should instantly disable processing of the effect. But turning the effect off for a particular channel should keep processing the effect, but just cut the input completely. This doesn't solve the question of the distort effect, though, because by this logic either all channels always have the distortion hum if that effect is enabled.

This leads me to conclude that the effect-enabled buttons in the skins should be three-state: process both input and output, process output only (mute input), and off. Click the button once turns it on, clicking it again cuts input but keeps output going, and clicking again disables it for that channel. I think that covers all the use cases and then we don't need to code a possibly-flaky "settling" algorithm.