Looks good to me.
We still need a timeout to progressively turn the effect output off, just in case an effect ignores the "your input is off" signal Mixxx sends to it. This is also needed for external effects for which Mixxx can't send such a signal.
Looks good to me.
We still need a timeout to progressively turn the effect output off, just in case an effect ignores the "your input is off" signal Mixxx sends to it. This is also needed for external effects for which Mixxx can't send such a signal.