Comment 11 for bug 1481170

Revision history for this message
Ferran Pujol (ferranpujol) wrote :

A three state switch. I'm not sure what happens when an effect is switched I don't own any.

Anyway, release effects is a complex feature. Let me focus on the specific request of this bug.

We could let the user either

1) turn off the effect completely (cut the output)

Or

2) cut the effect input signal and let the fx continue generating output. Mixxx monitors the effect output level and turns de effect off automatically when it is inaudible. If the effect output levels don't decrease enough after a certain amount of time, then Mixxx automatically performs a fade out and turns the effect off afterwards.

How to map this to the UI (after some thought, Owen's idea was not that bad! My apologies): just one button
Use it to enable the effect, the button lits.
Left click it to turn the effect off as described in 1), the button indicator turns off.
Right click it to turn off the effect as described in 2), while the effect still has audible output the button blinks.

For controllers we just need to map 2) to the controller fx on/off button with a shift modifier.

Do you like this approach?