Mixxx

  1. Bug #1464975
  2. Comment #1

Comment 1 for bug 1464975

Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

I've seen many occurrences of manual file path construction in the Mixxx code base. Instead QDir::filePath()/absoluteFilePath() should be used that eliminates all redundant path separators.

One example from cmdlineargs.h:
   QDir::homePath().append("/").append(SETTINGS_PATH)
should be replaced by
   QDir::home().absoluteFilePath(SETTINGS_PATH)
which is safer and simpler.

Looks like no one is reading their Qt API docs thoroughly ;) Composition of file paths should never be done using low-level string concatenation.