Comment 43 for bug 1329202

Revision history for this message
Marco Pracucci (marco-pracucci) wrote : Re: [Bug 1329202] Re: Live Broadcasting - Warn if Mount is not escaped when sending metadata

Yes, this completely break what we do.

Sorry to be rude, but this issue is becoming a fucking nightmare for us.
After weeks, each of the proposed solution and patch doesn't fix anything
and just introduce more issues. Rolling back and keeping the current
behaviour looks the best solution to me.

Marco

2015-11-22 13:17 GMT+01:00 Florian Kiekhäfer <email address hidden>:

> I doubt that is, what marco wanted...
>
> Especially as i did not find a player with which i could listen to the
> streams, when i entered the already encoded mount-name in mixxx...
>
> I guess it could even break what Spreaker tries to do completely...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1329202
>
> Title:
> Live Broadcasting - Warn if Mount is not escaped when sending metadata
>
> Status in Mixxx:
> Confirmed
>
> Bug description:
> The "Live Broadcasting" > "Mount" field value is sent as an
> *unescaped* query string parameter when Mixxx sends metadata to the
> icecast server.
>
> This lead to the following bug (actual behavior):
> - Mount set to "/live?stream_id=1&tracking=2"
> - Mixxx builds the metadata URI like
> "/admin/metadata?mode=updinfo&mount=/live?stream_id=1&tracking=2&song=title"
> - As you can see, the mount query string parameter is *not escaped*, so
> it's not possible to correctly parse the "mount" parameter
>
> How it should be (expected behavior):
> - Mount set to "/live?stream_id=1&tracking=2"
> - Mixxx builds the metadata URI like
> "/admin/metadata?mode=updinfo&mount=2Flive%3Fstream_id%3D1%26tracking%3D2&song=title"
>
>
> Mixxx: 1.11.0
> Operating System: OSX 10.8.5
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1329202/+subscriptions
>