Do not allow to activate Vinyl Control & Passthrough if no input devices are selected

[jus]

In 1.10, users get the "No input device(s) select.
Please select your soundcard(s) in the sound hardware preferences." warning, when activating Vinyl control without having a valid input device selected.

In current master, there is no feedback at all. We should give at least give a warning, with a more precise text.

[jus (jus)]

This goes along with lp:1203775

[Owen Williams (ywwg)]

can you retest this? I believe it's fixed.

[jus (jus)]

Looks like it is not fixed. We have this in the default keyboard cfg:

[Channel1]
passthrough Ctrl+j

[Channel2]
passthrough Ctrl+k

If no passthrough device is selected in the preferences, pressing one of the shortcuts does nothing than altering the gain & waveform of the track currently playing in a deck. IIRC this is different from the last time i tested, where the playing deck at least stopped when activating passthrough, now playback continues.

-------------------------------------
[Passthrough1]
passthrough_enabled Ctrl+j

[Passthrough2]
passthrough_enabled Ctrl+k

When using these alternative shortcuts to activate passthrough instead, i get continuous "Warning []: ERROR: Buffer overflow in EnginePassthrough. Dropping samples on the floor. "

Probably an aspect of lp:1265247

[Owen Williams (ywwg)]

This is working for me again, please check current trunk?

[jus (jus)]

Thanks,
a popup is displayed again when i try to activate VC if no VC input devices are configured.

OTOH activating passthrough now stop the deck, which is good, but i think displaying the pop-up similar to VC would be nice to have. If one has no AUX inputs configured, passthrough does nothing and might confuse users.

[Owen Williams (ywwg)]

Ah ok. I can add a check for that.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7201