passthrough enabling not working

Bug #1265247 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Unassigned

Bug Description

The passthrough object is listening for [PassthroughX], passthrough_enabled but the deck itself is listening for [ChannelX], passthrough. As a result, two COs must be separately triggered to enable passthrough, which is wrong.

Tags: vinylcontrol
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

While someone's on this, since "passthrough" is in the namespace, shouldn't the item be called just "enabled"?

Revision history for this message
jus (jus) wrote :

Is possibly the reason for lp:1219456 too.
Also explains why the original controls do not work, see https://bugs.launchpad.net/mixxx/+bug/355945/comments/11

tags: added: vinylcontrol
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

The names are more uniform now. I think this is fixed.

To summarize: we have, Vinyl Control Passthrough and Auxiliary inputs and they aren't connected in any way.

VC Deck passthrough : Enabled with [ChannelX],passthrough
VC Deck: Input is configured not indicated by any control.

Auxiliary inputs: Input is configured indicated by [AuxiliaryX],enabled -- should be read-only.
Auxiliary inputs: Enabled with [AuxiliaryX],passthrough

Microphone inputs: input is configured indicated by [Microphone/X],enabled -- should be read only
Microphone inputs: Enabled with [Microphone/X],talkover

I think aux inputs should not be toggle-able or at least default to on. Thoughts?

Revision history for this message
Owen Williams (ywwg) wrote :

Yeah if an aux is hooked up it should be active. Disabling it should be done with a mute button.

Owen Williams (ywwg)
Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7246

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.