Comment 8 for bug 1184581
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote Re: Control lookups in MidiController | #8 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
There are 2 lookups now (1 is unavoidable).
The second one is calling CO::getControl() for each input mapping. We could cache the CO in the MIDI input mapping to eliminate this after the first lookup. The problem is that this would assume the ControlObject* for a ConfigKey never changes and that is not necessarily true (for example, skin-generated controls).
Given that we have no profiling data showing this inefficiency actually causes any problems -- moving out of 1.12.0 and marking low.