- if (newPlaylistId != -1) {
+ if (newPlaylistId != -1
+ && m_playlistDao.copyPlaylistTracks(oldPlaylistId, newPlaylistId)) emit(showTrackModel(m_pPlaylistTableModel));
- }
When an expression is dangling across lines, please keep the logic operator (e.g. the &&) at the end of the line so that as you scan, you naturally see the expression is continued because the binary operator is there without its right operand. Also, single line bodies of if statements should have braces.
The time-only in session playlists is intentional -- Daniel did that when he wrote the feature, I think to allow you to more easily tell how far into your set you played the track. If that was the intention then I think we should be showing the (date - first-track-start-date) as a duration instead. Daniel -- can you comment?
Thanks Steven! Committed to lp:mixxx/1.11
Minor style issue for future ref:
- if (newPlaylistId != -1) { copyPlaylistTra cks(oldPlaylist Id, newPlaylistId))
emit( showTrackModel( m_pPlaylistTabl eModel) );
+ if (newPlaylistId != -1
+ && m_playlistDao.
- }
When an expression is dangling across lines, please keep the logic operator (e.g. the &&) at the end of the line so that as you scan, you naturally see the expression is continued because the binary operator is there without its right operand. Also, single line bodies of if statements should have braces.
The time-only in session playlists is intentional -- Daniel did that when he wrote the feature, I think to allow you to more easily tell how far into your set you played the track. If that was the intention then I think we should be showing the (date - first-track- start-date) as a duration instead. Daniel -- can you comment?