Comment 18 for bug 1160353

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I committed a fix for the deadlock -- it's a pretty simple one:
http://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.11.x/revision/3797
MessageHandler's mutex is only meant to protect Logfile but it is held while calling ErrorDialogHandler (which is already thread safe) so that is why re-entrancy in MessageHandler can deadlock. The solution is to just unlock before calling ErrorDialogHandler.