Comment 10 for bug 1156569

Revision history for this message
James Fagan (jfagan1) wrote :

I apologize for all the questions but I am still somewhat confused about how I actually determine whether a sample is of type SAMPLE or CSAMPLE. Also to clarify the problem I am trying to fix is that everytime a sample is brought into mixxx it is automatically read in by soundsource.h 's read method as a SAMPLE and then everywhere else in the code that sample may be used it must be converted to CSAMPLE. This is the problem because if we have a file that is orignally above 16 bits (CSAMPLE) it is converted to SAMPLE by the read method and then back to CSAMPLE later; so we have 2 extra conversions for no reason. What I don't understand is when a sample is brought into mixxx, how can I just read it in as a CSAMPLE or a SAMPLE if I don't actually know what it is?

Thanks,
James