engine.spinback & engine.brake fix / ideas

[x]

When invoked, each of these effects cause the track to stop, but remain "playing". The track will then not play until I touch the jog wheel.

I have mapped these effects such that when the button linked to it is pressed, the track either spins back and stops or brakes and stops (they are not press and hold).

Having the track NOT pause (so staying like it is) is desirable when using slip mode and looprolls, but is undesirable when using the effects to stop the track.

I propose this:

Would it be possible to split each function into two separate functions, one that executes the effect and then continues playing (this is more for the brake effect) and another that can be used to stop the track?

[Sean M. Pappalardo (pegasus-renegadetech)]

This shouldn't be too hard to add. I'll take a look at this.

[RJ Skerry-Ryan (rryan)]

Sean, did you find anything here? I'm freeing this up for someone else to take a look. Feel free to re-assign.

[Chloé AVRILLON (chloe-avrillon)]

In fact the deck continue to play when you stop the effect before it stops the track.
In my mapping for the reloop beatpad it does the brake while the button is hold down. As soon as you release the button it stops the brake effect. If the effect did not stop the track completely the playback continues.
It could be handy to have a callback to know if the effect stopped completely or not. May be the getValue(group,"play ) is enough to do it, I don't know.

[ronso0 (ronso0)]

I agree with Chloé: I used brake() in my controller script to slowly stop the deck when respective button is pressed & released. Touching & releasing jogwheel before stopped (deactiving scratch mode) causes the track to continue to play at normal speed. Code is there:
https://bugs.launchpad.net/mixxx/+bug/1571442/comments/1
This also considers actual rate, just in case track is pitched).

I also agree to splitting brake/spinback into two functions.

Funny effect is when track is not playing and you trigger brake/spinback: it plays at 100% then slows down/spins back. Which brings me to the idea to incorporate another function which I'd call softStart. Already tried to modify brake to do this in /src/controllers/controllerengine.cpp, but half-assed. Is Daniel referring to this here https://bugs.launchpad.net/mixxx/+bug/692928 ?

softStart:
* Track is not playing
* trigger softStart
* track speeds up from zero to normal speed (considering pitch slider, of course)

I filed a bug here:

I can imagine to take over those bugs somewhere around Christmas

[ronso0 (ronso0)]

uups, here it is
https://bugs.launchpad.net/mixxx/+bug/1643720

[ronso0 (ronso0)]

@Chloe @x
There are some fixes in https://github.com/mixxxdj/mixxx/pull/1226, could you test it please?

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6779