Mixxx

  1. Bug #1024621
  2. Comment #27

Comment 27 for bug 1024621

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Good call on the queue in CachingReader. I wasn't thinking :).

v3 looks good.. please commit it!

* In EngineBuffer I think we can get rid of playButtonCOT and just use playButton since it's no longer in the main thread and playButtonCOT is a ControlObjectThreadMain. All the other uses of playButton might come from other threads so it seems to be fine anyway.

* EngineControl needs an empty slotTrackLoading method added since you connect that signal in EngineBuffer::addControl(). Or you could remove that connect() until we need to use that signal in an EngineControl.