Comment 5 for bug 1008721
Revision history for this message
| Daniel Schürmann (daschuer) wrote Re: AnalyserGain before AnalyserWaveform | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
OK I have retested 1.10.1, and you are right, the behavior is the same. I just haven't notice the problem in 1.10 until now.
Let me explain:
Some of my tracks have a calculates replay gain and some not. I don't keep track of that.
For my feeling the overview waveform takes the part of an analysis progress bar of a loaded track.
Assuming the analysis has entirely finished when the waveform is entirely drawn,
I have pressed play and heard a volume that is above what I had expected.
After some seconds it drops to normal due the actual finishing of finalize().
With the patch "analysis finished" is reported when analysis is actual finished.
An ADDITIONAL action would be not to change replay gain for PLAYING tracks.
This will fit perfectly to my patch because if the user starts the deck before replay gain analysis has finished he did not face a volume drop and if he starts later the replay gain is adopted. The user can clearly see by the progress the waveform overview waveform what will happen. With this we will get also rid of the reload meta data warning.