Comment 6 for bug 1000431

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi RJ,

I just wonder why you think comparing the track Ids will not work.
For the setlog feature every track played has to be stored in the mixxx database and must have a track ID.
This should already be the case. If not, it is a different bug.
A Track without a track ID can not be listed in the set log play list.

see:
src/library/rhythmbox/rhythmboxtrackmodel.cpp line 50.

I would prefer to compare the unique track ID, because i am not sure if a pointer compare is valid in all conditions.
Does storing it in a Linked list increment the reference counter of the shared pointer?
Does this introduce a second kind of (not intended) track cache?
We will get a new pointer address if the track falls out of cache and the comparison fails or furthermore can it be false equal?

Kind regards,
Daniel