Mir

  1. Bug #1480755
  2. Comment #3

Comment 3 for bug 1480755

Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: [regression] Some Mir EGL demos don't get bypassed any more in fullscreen

Bisected. The regression came in r2771:

------------------------------------------------------------
revno: 2771 [merge]
author: Daniel van Vugt <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2015-07-23 06:36:32 +0000
message:
  Add a new client function: mir_connection_get_egl_pixel_format
  that solves the ambiguity in matching an EGLConfig with the correct
  MirPixelFormat.

  Although we've got by with guessing until now, that only works with
  a very small number of pixel formats and is not reliable as we add
  more formats and more platforms.

  It turns out Android already solved this with its standard extension
  "EGL_KHR_platform_android", so we use that. As for mesa-kms, it turns
  out GBM really only supports two pixel formats correctly so is easy
  to match those up. Fixes: https://bugs.launchpad.net/bugs/1460149.

  Approved by Daniel van Vugt, PS Jenkins bot, Kevin DuBois, Chris Halse Rogers, Robert Carr, Alberto Aguirre.
------------------------------------------------------------

Since then, the affected demo clients are choosing mir_pixel_format_argb_8888 (previously they chose mir_pixel_format_xrgb_8888), and our bypass logic obviously checks for an alpha channel (which is technically the correct thing to do).