Comment 3 for bug 1390388

OK, finally got a phone into a state where I could run -r 2043 of lp:~alan-griffiths/mir/fix-1390388. Here's the result:

Running main() from command_line_server_configuration.cpp
Note: Google Test filter = StaleFrame*
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from StaleFrames
[ RUN ] StaleFrames.are_dropped_when_restarting_compositor
DEBUG (BufferBasic() ctor): buffer id:0
DEBUG (BufferBasic() ctor): buffer id:1
DEBUG (deposit_package): buffer id:0
DEBUG (194): buffer id:3
DEBUG (BufferBasic() ctor): buffer id:2
DEBUG (deposit_package): buffer id:2
DEBUG (198): buffer id:3
DEBUG (deposit_package): buffer id:1
/tmp/buildd/mir-0.8.0+14.10.20141010bzr2043pkg0vivid16+autopilot0/tests/integration-tests/test_stale_frames.cpp:202: Failure
Value of: stale_buffers.size()
Expected: is equal to 2
  Actual: 1 (of type unsigned int)
DEBUG (204): buffer id:3
DEBUG (deposit_package): buffer id:0
[ FAILED ] StaleFrames.are_dropped_when_restarting_compositor (270 ms)
[ RUN ] StaleFrames.only_fresh_frames_are_used_after_restarting_compositor
DEBUG (BufferBasic() ctor): buffer id:3
DEBUG (BufferBasic() ctor): buffer id:4
DEBUG (deposit_package): buffer id:3
DEBUG (224): buffer id:3
DEBUG (BufferBasic() ctor): buffer id:5
DEBUG (deposit_package): buffer id:5
DEBUG (226): buffer id:3
DEBUG (deposit_package): buffer id:4
DEBUG (229): buffer id:3
DEBUG (deposit_package): buffer id:3
/tmp/buildd/mir-0.8.0+14.10.20141010bzr2043pkg0vivid16+autopilot0/tests/integration-tests/test_stale_frames.cpp:237: Failure
Value of: new_buffers[0]
Expected: is equal to 3
  Actual: 4
[ FAILED ] StaleFrames.only_fresh_frames_are_used_after_restarting_compositor (234 ms)
[----------] 2 tests from StaleFrames (506 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (508 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] StaleFrames.are_dropped_when_restarting_compositor
[ FAILED ] StaleFrames.only_fresh_frames_are_used_after_restarting_compositor

 2 FAILED TESTS

Clearly the buffers are getting sane IDs but result of mir_debug_surface_current_buffer_id() is wrong and that's what causes the test to fail.

Dunno why though.

Steps to reproduce (not necessarily optimal):

ubuntu-device-flash --channel=ubuntu-touch/vivid-proposed
phablet-config writable-image --remotepassword ****
 wget http://s-jenkins.ubuntu-ci:8080//view/mediumtests/job/mir-mediumtests-builder-vivid-armhf/16/artifact/*zip*/archive.zip
adb shell mkdir /home/phablet/mirtest
adb push archive.zip /home/phablet/mirtest
adb shell

(now on device)

sudo apt-get install unzip
cd /mirtest
unzip archive.zip
cd archive/work//output/
dpkg -i *
sudo apt-get install -f
dpkg -i *
mir_integration_tests --gtest_filter=StaleFrame*