Use of anonymous struct in MirMotionEvent makes hard to use API

[Robert Ancell]

MirMotionEvent looks like this:

typedef struct
{
    MirEventType type;
    ...
    size_t pointer_count;
    struct
    {
        int id;
        ...
    } pointer_coordinates[MIR_INPUT_EVENT_MAX_POINTER_COUNT];
} MirMotionEvent;

If you want to iterate over pointer_coordinates you need to code something like this:

MirEventMotion *e;
for (i = 0; i < e->pointer_count; i++)
    printf ("%f, %f\n", e->pointer_coordinates[i].x, e->pointer_coordinates[i].y);

It is desirable to be able to get a pointer to each coordinate to make this easier to type, i.e.

MirEventMotion *e;
for (i = 0; i < e->pointer_count; i++)
{
    MirPointerCoordinate *p = &e->pointer_coordinates[i];
    printf ("%f, %f\n", p->x, p->y);
}

This requires the structure to have a name.

[Daniel van Vugt (vanvugt)]

If you're in C++ you could do this (or something like it):

    auto p0 = &e->pointer_coordinates[0];
    for (int i = 0; i < e->pointer_count; ++i)
    {
        auto &p = p0[i];
        // use p
    }

[Robert Ancell (robert-ancell)]

I'm in C :)