@gotik_,
i wonder if the name->title thing is a good idea, alltogether...
i mean, this bikeshedding tends to dominate your patch, which make me lose track of the substantial change. not to mention the compatibility issue with the search engines.
more to the point, every time i add or edit a bookmark i get a warning:
Gtk-WARNING **: gtkliststore.c:797: Invalid column number 170105136 added to iter (remember to end your list of columns with a -1)
eventually, this seems to lead to a crash (hard to reproduce) when adding a bookmark i got this:
<<<
Gtk-CRITICAL **: IA__gtk_tree_store_insert_with_values: assertion `GTK_IS_TREE_STORE (tree_store)' failed
Gtk-CRITICAL **: IA__gtk_tree_model_iter_n_children: assertion `GTK_IS_TREE_MODEL (tree_model)' failed
>>>
then a segfault:
<<<
Program terminated with signal 11, Segmentation fault.
#0 0xb76de23e in g_type_check_instance_cast () from /usr/lib/libgobject-2.0.so.0
(gdb) bt 2
#0 0xb76de23e in g_type_check_instance_cast () from /usr/lib/libgobject-2.0.so.0
#1 0x08070b9b in midori_bookmarks_add_item_cb (array=0x9389b18, item=0x97e4090,
bookmarks=0x98beef0) at ../panels/midori-bookmarks.c:320
(More stack frames follow...)
(gdb) frame 1
#1 0x08070b9b in midori_bookmarks_add_item_cb (array=0x9389b18, item=0x97e4090,
bookmarks=0x98beef0) at ../panels/midori-bookmarks.c:320
320 model = gtk_tree_view_get_model (GTK_TREE_VIEW (bookmarks->treeview));
(gdb) p bookmarks->treeview
$1 = (GtkWidget *) 0x7
(gdb) p *bookmarks->treeview
Cannot access memory at address 0x7
(gdb) p *bookmarks
$2 = {parent_instance = {box = {container = {widget = {object = {parent_instance = { g_type_instance = {g_class = 0x941f0f8}, ref_count = 5, qdata = 0x996b3f0},
flags = 6359008}, private_flags = 3584, state = 0 '\000', saved_state = 0 '\000',
name = 0x0, style = 0x9402400, requisition = {width = 104, height = 19}, allocation = {
x = 0, y = 230, width = 183, height = 21}, window = 0x9920d80, parent = 0x97e8768},
focus_child = 0x0, border_width = 0, need_resize = 0, resize_mode = 0, reallocate_redraws = 0, has_focus_chain = 0}, children = 0x9880900, spacing = 0,
homogeneous = 0}}, toolbar = 0x992b218, edit = 0x15, delete = 0x0, treeview = 0x7,
app = 0x0, array = 0x98c5400, filter_timeout = 0, filter = 0x0}
>>>
@gotik_,
i wonder if the name->title thing is a good idea, alltogether...
i mean, this bikeshedding tends to dominate your patch, which make me lose track of the substantial change. not to mention the compatibility issue with the search engines.
more to the point, every time i add or edit a bookmark i get a warning:
Gtk-WARNING **: gtkliststore.c:797: Invalid column number 170105136 added to iter (remember to end your list of columns with a -1)
eventually, this seems to lead to a crash (hard to reproduce) when adding a bookmark i got this: tree_store_ insert_ with_values: assertion `GTK_IS_TREE_STORE (tree_store)' failed tree_model_ iter_n_ children: assertion `GTK_IS_TREE_MODEL (tree_model)' failed
<<<
Gtk-CRITICAL **: IA__gtk_
Gtk-CRITICAL **: IA__gtk_
>>>
then a segfault: check_instance_ cast () from /usr/lib/ libgobject- 2.0.so. 0 check_instance_ cast () from /usr/lib/ libgobject- 2.0.so. 0 bookmarks_ add_item_ cb (array=0x9389b18, item=0x97e4090, 0x98beef0) at ../panels/ midori- bookmarks. c:320 bookmarks_ add_item_ cb (array=0x9389b18, item=0x97e4090, 0x98beef0) at ../panels/ midori- bookmarks. c:320 view_get_ model (GTK_TREE_VIEW (bookmarks- >treeview) ); >treeview
g_type_ instance = {g_class = 0x941f0f8}, ref_count = 5, qdata = 0x996b3f0},
reallocate_ redraws = 0, has_focus_chain = 0}, children = 0x9880900, spacing = 0,
<<<
Program terminated with signal 11, Segmentation fault.
#0 0xb76de23e in g_type_
(gdb) bt 2
#0 0xb76de23e in g_type_
#1 0x08070b9b in midori_
bookmarks=
(More stack frames follow...)
(gdb) frame 1
#1 0x08070b9b in midori_
bookmarks=
320 model = gtk_tree_
(gdb) p bookmarks->treeview
$1 = (GtkWidget *) 0x7
(gdb) p *bookmarks-
Cannot access memory at address 0x7
(gdb) p *bookmarks
$2 = {parent_instance = {box = {container = {widget = {object = {parent_instance = {
flags = 6359008}, private_flags = 3584, state = 0 '\000', saved_state = 0 '\000',
name = 0x0, style = 0x9402400, requisition = {width = 104, height = 19}, allocation = {
x = 0, y = 230, width = 183, height = 21}, window = 0x9920d80, parent = 0x97e8768},
focus_child = 0x0, border_width = 0, need_resize = 0, resize_mode = 0,
homogeneous = 0}}, toolbar = 0x992b218, edit = 0x15, delete = 0x0, treeview = 0x7,
app = 0x0, array = 0x98c5400, filter_timeout = 0, filter = 0x0}
>>>