Comment 46 for bug 836707

Revision history for this message
vcap (vcappe) wrote :

Doesn't build as-is with current git master, because main() still use the bookmarks_exist variable in the old conversion code. The "else if (!bookmarks_exist)" branch, there, should probably be removed too (which i assume is how it is on your local branch, but it's still there in master).

Also, the fact that midori_bookmarks_initialize doesn't take a filename anymore breaks my unit test code which relied upon being able to give ":memory" there (yeah, i am the one to blame for this).

What happened to the end of midori_bookmarks_import_from_old_db? Why are we g_printing the error message instead of setting the caller-provided errmsg pointer.

Sounds good, otherwise.