Comment 19 for bug 836707

Revision history for this message
Alexander Butenko (avb) wrote :

I think thats one more point you need to elaborate in your patch. I havent paid an attention that bookmarks parent != katzeItem parent. Thats for sure will be a problem in code readability after. Let me know what do you think

avb1: kalikiana: what do you think about katze_item_get_id?
avb1: he added new int64 member
avb1: i think we can go with katze_item_get_meta_integer
avb1: but both ways looks ok for me
avb1: except that im aware of some side effects from new member
kalikiana: avb1: my criteria would be 2: is it performance-critical? is it useful outside of bookmarks (history, search)?
kalikiana: if speed is not an issue, meta integer tends to make clear that it's an addon sort of thing
kalikiana: I wonder about the folder/parent change
kalikiana: I'm not sure if that is more than a rename
kalikiana: it could be misleading given that the parent normally is _get_parent, ie a real object
kalikiana: opinions on that?
natano: where can is see the patch?
avb1: kalikiana: agree
avb1: thats where was my concent
avb1: he is missing a fact that katzeitem is used not only for bookmarks
avb1: and yes, bookmarks parent != katzeItem parent