Comment 2 for bug 826441

Revision history for this message
Cris Dywan (kalikiana) wrote :

There's no need to keep seprarate labels in WebKitWebSettings - if you saw it elsewhere it was because WebKit built-in settings were used and didn't have nice, translated labels.
I wouldn't bother to add authors for one-liners like in katze-utils.c. Your credit still appears in the git log and the headers would be crowded very easily otherwise ;-)
And "Since: 0.4.2 now effectively".
^^ Updated patch attached.

midori_browser_settings_notify leaks "family".

_midori_browser_forced_font sort of touches a general question: what to use user-stylesheet-uri for. There's been ideas but somehow we were stuck not using it at all. I'll add some names on the bug for that reason.
I think it would be better to do this from inside MidoriWebSettings to keep it flexible.

Do we actually need to duplicate the font family and size values? Kevin? Maybe we should just operate on both proportional and monospace font and override with whatever given values?