Comment 13 for bug 783675

Revision history for this message
Peter Hatina (phatina) wrote :

Christian, I haven't noticed, that you added _toggle_tabbar_smartly. OK, I assume, this should be used for fullscreen way (as unfullscreen). In that function you are using midori_browser_is_fullscreen, which can return false value due to compositor state. I moved the code, which takes care of showing/hiding necessary widgets, into midori_browser_window_state_event_cb, where the midori_browser_is_fullscreen returns the correct value and fullscreen will work without any problem.

After your patch (Teach _toggle_tabbar_smartly what fullscreen means), you added only one call _toggle_tabber_smartly. Having that call added also to fullscreen, tabs wouldn't be shown on the very first call.

Maybe, we can meet our opinions, this might be the best way, can't we?