Comment 10 for bug 783675

Revision history for this message
Cris Dywan (kalikiana) wrote :

Peter, I'm afraid that patch is wrong in that form. There are several ways to create a tab, from a URI, item or widget. Ultimately midori_browser_add_tab is the one that is *always* called. Further more _toggle_tabbar_smartly is the canonical place to say if the tab bar should be there or not.
So I refined _toggle_tabbar_smartly and also introduced midori_browser_is_fullscreen to simplify some code. Unfortunately I had to add a boolean ignore_fullscreen for the case where "fullscreen becomes normal" and the window state has not yet been updated. I hesitated to keep state in the browser.