undocking and redocking webkit inspector causes crash

[nirik]

Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=691024

from there:

How to reproduce
-----
1. open midori (wait for fedora start page to load)
2. open web-inspector
3. undock web-inspector
4. dock web-inspector
5. undock web-inspector
crash

I see this here on webkitgtk-1.3.13 and midori-0.3.3, orig reporter sees it on midori-0.2.9

Happy to provide more details.

[Alexandru (alexandru-redhat-bugs)]

abrt version: 1.1.17
architecture: i686
Attached file: backtrace, 43629 bytes
cmdline: midori /home/alexandruz/tmp/src/proiect/util21.ro/www.util21.ro/afaceri/firme-de-constructii-din-Arad.htm
component: midori
Attached file: coredump, 161320960 bytes
crash_function: globalData
executable: /usr/bin/midori
kernel: 2.6.35.11-83.fc14.i686.PAE
package: midori-0.2.9-4.fc14
rating: 4
reason: Process /usr/bin/midori was killed by signal 11 (SIGSEGV)
release: Fedora release 14 (Laughlin)
time: 1301129911
uid: 500

How to reproduce
-----
1. open-close "web-inspector"
2.
3.

[Alexandru (alexandru-redhat-bugs)]

Created attachment 487720
File: backtrace

[Kevin (kevin-redhat-bugs)]

What does:

rpm -q webkitgtk

return? This looks like a webkit crash... can you attach the contents of the .html file?
Does the crash happen every time?

[Alexandru (alexandru-redhat-bugs)]

Package: midori-0.2.9-4.fc14
Architecture: i686
OS Release: Fedora release 14 (Laughlin)

How to reproduce
-----
1. open midori (wait for fedora start page to load)
2. open web-inspector
3. undock web-inspector
4. dock web-inspector
5. undock web-inspector
crash

[Alexandru (alexandru-redhat-bugs)]

webkitgtk-1.3.10-1.fc14.i686

seems to crash on every page with that routine (dock-undock)

[Kevin (kevin-redhat-bugs)]

Can you try with this scratch build of midori 0.3.3:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2950782

[Kevin (kevin-redhat-bugs)]

Yeah, I can duplicate this on f15 too with the newest midori. ;)

Will try and see if upstream can make anything of it.

[Kevin (kevin-redhat-bugs)]

Filed upstream:

https://bugs.launchpad.net/midori/+bug/746540

[André Stösel (ivaldi)]

Please try the following patch.

[Cris Dywan (kalikiana)]

I committed the above patch. I added a doc comment to the signal, mainly to make sure we have a Since for reference.

Nirik, please give it a go since it's unclear if this is the same issue.

[nirik (kevin-scrye)]

sadly I am traveling this week and can't really easily test. ;(

will do so when I get back this coming weekend.

[Kevin (kevin-redhat-bugs)]

Can you try this scratch build?

http://koji.fedoraproject.org/koji/taskinfo?taskID=2979025

It's a prerelease git snapshot, but has a fix for this issue in it.
Would be good to confirm, then I could look at backporting the patch/fix.

[Alexandru (alexandru-redhat-bugs)]

Can you build that again for f15 (as I did an upgrade)?

[Kevin (kevin-redhat-bugs)]

ok, try:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2996682

[Alexandru (alexandru-redhat-bugs)]

ok, this seems to be ok, no more crashing on "dock-undock"

[nirik (kevin-scrye)]

This does fix the issue I can confirm. ;)

Thanks for the fast fix and merge into upstream!

[Kevin (kevin-redhat-bugs)]

ok. This fix is already merged upstream and should be in 0.3.4, so not sure how much it's worth backporting it.

I'll go ahead and close this UPSTREAM, and we should pick up the fix in 0.3.4.

If you would like me to backport this, feel free to reopen and discuss.

Thanks!