Comment 2 for bug 1087251

Revision history for this message
Paul Menzel (pm-debian) wrote : Re: [Bug 1087251] [NEW] Left part of URL in URL search bar sometimes truncated

Am Donnerstag, den 06.12.2012, 13:10 +0000 schrieb Paul Menzel:
> Public bug reported:
>
> Please see the attached screenshot for the truncated URL.
>
> In #midori I was given a patch to try and I will report back.

The patch

        $ more /tmp/fix.diff
        diff --git i/midori/midori-locationaction.c w/midori/midori-locationaction.c
        index c8fa3ea..79b3731 100644
        --- i/midori/midori-locationaction.c
        +++ w/midori/midori-locationaction.c
        @@ -714,7 +714,7 @@ midori_location_action_popup_timeout_cb (gpointer data)
                     "cell-background", MIDORI_AUTOCOMPLETER_COLUMNS_BACKGROUND,
                     NULL);
                 renderer = gtk_cell_renderer_text_new ();
        - #if HAVE_GRANITE
        + #ifdef HAVE_GRANITE
                 gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (column), renderer, FALSE);
                 #else
                 gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (column), renderer, TRUE);
        @@ -722,7 +722,7 @@ midori_location_action_popup_timeout_cb (gpointer data)
                 gtk_cell_layout_set_attributes (GTK_CELL_LAYOUT (column), renderer,
                     "cell-background", MIDORI_AUTOCOMPLETER_COLUMNS_BACKGROUND,
                     NULL);
        - #if HAVE_GRANITE
        + #ifdef HAVE_GRANITE
                 gtk_tree_view_column_set_expand (column, TRUE);
                 gtk_cell_layout_set_cell_data_func (GTK_CELL_LAYOUT (column), renderer,
                     midori_location_entry_render_title_cb, action, NULL);

did not help.

Running `./waf check` after applying

        $ git diff
        diff --git a/tests/magic-uri.c b/tests/magic-uri.c
        index 75b7456..e6ae28c 100644
        --- a/tests/magic-uri.c
        +++ b/tests/magic-uri.c
        @@ -314,6 +314,7 @@ magic_uri_prefix (void)
                 { "http://example.com", "example.com" },
                 { "https://example.com", "example.com" },
                 { "file:///path/to/my/heart", "/path/to/my/heart" },
        + { "https://bugs.launchpad.net/midori/", "bugs.launchpad.net/midori/" },
              };
             guint i;

also did not give any errors, that means the tests passed.

Here is some more information. The trigger seems to be the spaces in the
search term.

I have for example »planet.debian.org« in my history and also
»bugs.debian.org«.

Entering »p debian o« all URLs with planet.debian.org in them just show
`.org…`. The bugs.debian.org URLs are shown fully. Entering »pla deb o«
I just see »ian.org« for the URLs.