pagination links have incorrect endpoint names

[Goutham Pacha Ravi]

This bug is a continuation of https://bugs.launchpad.net/manila/+bug/2023754 and is related to https://bugs.launchpad.net/manila/+bug/2058424 but not the same issue.

Manila's API has a problem generating pagination links ("href" field of "self", "next", "bookmark" items) when the collection name (for example: "share_groups") is different from the route name (for example: "share-groups").

The fix for https://bugs.launchpad.net/manila/+bug/2023754 introduced an alias for this sort of situation. This alias ("self._collection_route_name") can be set by view builders whose route name and collection name differ. We should apply this fix to all other inconsistent resources:

- share groups: https://docs.openstack.org/api-ref/shared-file-system/index.html#share-groups-since-api-v2-31
- share backups: https://docs.openstack.org/api-ref/shared-file-system/index.html#share-backups-since-api-v2-80
- resource locks: https://docs.openstack.org/api-ref/shared-file-system/index.html#resource-locks-since-api-v2-81
- share group snapshots: https://docs.openstack.org/api-ref/shared-file-system/index.html#list-share-group-snapshots
- share group snapshot members: https://docs.openstack.org/api-ref/shared-file-system/index.html#list-share-group-snapshots-members
- share transfers: https://docs.openstack.org/api-ref/shared-file-system/index.html#share-transfer-since-api-v2-77

In all of these, the self._collection_name attribute of their view builders doesn't match the route name.. Most of them have a hyphen in the route name (e.g.: share-backups) and an underscore in the collection name (e.g: share_backups) which causes the links to be incorrect.

[christian okeke (ccokeke)]

Thanks Goutham for reporting this issue. I will go ahead and fix the broken link for the shared resources as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/913987

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/915340