"next links" broken for limited share replicas api

[Maurice Escher]

Hi,

the link to get the next share replica when using pagination is broken, it reports the URL with underscore 'share_replicas' whereas it should be with hyphen 'share-replicas':

https://paste.opendev.org/show/820352/

Now I cannot use that link to get the next share replica(s).

Briefly looked into the code, the `_get_next_link` method uses the `_collection_name` which is not right in this case, since the collection name and URL route are different for share replicas.

BR,
Maurice

credit to: kayrus

[Vida Haririan (vhariria)]

See additional related discussions at https://meetings.opendev.org/meetings/manila/2023/manila.2023-06-29-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/911709

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/911709
Committed: https://opendev.org/openstack/manila/commit/c8236141f86fc609ee9901a42bbcffe60bd66e40
Submitter: "Zuul (22348)"
Branch: master

commit c8236141f86fc609ee9901a42bbcffe60bd66e40
Author: Okeke Christian <email address hidden>
Date: Thu Mar 7 14:03:13 2024 +0100

    Fix the link to get the next share replica

    The url to get the next share replica is broken when performing
    pagination. The new API uses underscore to represent resource.
    This fix resolves the broken link for share replicas by using alias.

    Closes-bug: #2023754
    Change-Id: I31e32c0bcfb60b53121da9a96df3b44ad2b3ac67

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/manila/+/913803