Comment 13 for bug 1885956

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/rocky)

Reviewed: https://review.opendev.org/742123
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=11971a94d3205b42ee9e2f7c9978b4bb979fdd71
Submitter: Zuul
Branch: stable/rocky

commit 11971a94d3205b42ee9e2f7c9978b4bb979fdd71
Author: Tom Barron <email address hidden>
Date: Wed Jul 1 17:09:40 2020 -0400

    Enforce policy checks getting share-type by name

    Policy checks are skipped when looking up a share-type
    by name. This causes share creation attempts that specify
    a valid share-type to pass the early API check on share type
    even if the share type named is private and not shared with
    the user's project. The share creation fails later, but after
    the database record for the share is created. Although the
    operation fails with an ERROR, the share is stuck in CREATING
    state.

    Fix this issue by checking the user's project in the database
    API just as we do for share type lookups by uuid.

    Closes-bug: #1885956
    Change-Id: If5fe32c155fe0861b3ed86b862335e062796056b
    (cherry picked from commit f877deed5186cff3a7ecfbce2536e72fc6013895)
    (cherry picked from commit e02cc6d6bc92e354bc7f4220a05ec6fedf2ecc9c)
    (cherry picked from commit 2f2ed258f7c273543495b5476af2c3558d51384d)
    (cherry picked from commit 644cdf4e4ff965cb96b8cce5396042b6ac8abe7e)