Policy checks are skipped when looking up a share-type
by name. This causes share creation attempts that specify
a valid share-type to pass the early API check on share type
even if the share type named is private and not shared with
the user's project. The share creation fails later, but after
the database record for the share is created. Although the
operation fails with an ERROR, the share is stuck in CREATING
state.
Fix this issue by checking the user's project in the database
API just as we do for share type lookups by uuid.
Closes-bug: #1885956
Change-Id: If5fe32c155fe0861b3ed86b862335e062796056b
(cherry picked from commit f877deed5186cff3a7ecfbce2536e72fc6013895)
(cherry picked from commit e02cc6d6bc92e354bc7f4220a05ec6fedf2ecc9c)
(cherry picked from commit 2f2ed258f7c273543495b5476af2c3558d51384d)
Reviewed: https:/ /review. opendev. org/742043 /git.openstack. org/cgit/ openstack/ manila/ commit/ ?id=644cdf4e4ff 965cb96b8cce539 6042b6ac8abe7e
Committed: https:/
Submitter: Zuul
Branch: stable/stein
commit 644cdf4e4ff965c b96b8cce5396042 b6ac8abe7e
Author: Tom Barron <email address hidden>
Date: Wed Jul 1 17:09:40 2020 -0400
Enforce policy checks getting share-type by name
Policy checks are skipped when looking up a share-type
by name. This causes share creation attempts that specify
a valid share-type to pass the early API check on share type
even if the share type named is private and not shared with
the user's project. The share creation fails later, but after
the database record for the share is created. Although the
operation fails with an ERROR, the share is stuck in CREATING
state.
Fix this issue by checking the user's project in the database
API just as we do for share type lookups by uuid.
Closes-bug: #1885956 61b3ed86b862335 e062796056b 3a7ecfbce2536e7 2fc6013895) 4bc7f4220a05ec6 fedf2ecc9c) 43495b5476af2c3 558d51384d)
Change-Id: If5fe32c155fe08
(cherry picked from commit f877deed5186cff
(cherry picked from commit e02cc6d6bc92e35
(cherry picked from commit 2f2ed258f7c2735