NetApp driver fails trying to delete ipspace 'Default'

[Douglas Viroel]

Description
===========
NetApp driver is failing to delete a share server if: 1) it has no data SVMs on the current ipspace and it is using the cluster's Default ipspace. This issue happens only when operation in driver_handles_share_server == True and with network type set to 'Flat'.

Steps to reproduce
==================

In order to reproduce the error you must not have any other data SVM on Default ipspace.
The network type must be Flat, so NetApp driver can reuse the Default ipspace for the new LIF.
* Create a share
* Delete the share
* Delete the associated share server

Expected result
===============
Share server is deleted from Manila and from NetApp storage.

Actual result
=============
NetApp driver fails to delete the share server because it attempts to remove the Default ipspace.

Logs & Configs
==============

When deleting the Default ipspace, tries to delete the default broadcast domain and fails:

May 22 18:35:37.575031 template-devstack-xenial-1590123608 manila-share[25793]: ERROR manila.share.manager [None req-5c008c9b-d427-45fe-91ed-2139c9e33adc None None] Share server '23173455-7c88-4525-aa0c-e8e385121acd' failed on deletion.: manila.share.drivers.netapp.dataontap.client.api.NaApiError: NetApp API failed. Reason - 13001:Port "OSTK-select22-01:e0a" cannot be used because it is currently the home port or current port of a LIF. To view LIFs with a specified home port, use the "network interface show -home-node <nodename> -home-port {<netport>|<ifgrp>}" command. To view LIFs with a specified current port, use the "network interface show -curr-node <nodename> -curr-port {<netport>|<ifgrp>}" command.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/731238

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/731238
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=dbe34c08e2278eb472bc2cbf7f086d6deff7cab2
Submitter: Zuul
Branch: master

commit dbe34c08e2278eb472bc2cbf7f086d6deff7cab2
Author: Douglas Viroel <email address hidden>
Date: Tue May 26 19:38:56 2020 +0000

    [NetApp] Fix default ipspace deletion issue

    The NetApp driver is fixed to avoid the deletion of cluster
    ipspaces when deleting a share server. Now the share server
    deletion skip ipspace removal if the ipspace is one of the
    following: Cluster or Default.

    Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
    Closes-Bug: #1880747

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/731828

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/731828
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=2fe7452b1bf8b8975dcd663db3ecce98b5fb499c
Submitter: Zuul
Branch: stable/ussuri

commit 2fe7452b1bf8b8975dcd663db3ecce98b5fb499c
Author: Douglas Viroel <email address hidden>
Date: Tue May 26 19:38:56 2020 +0000

    [NetApp] Fix default ipspace deletion issue

    The NetApp driver is fixed to avoid the deletion of cluster
    ipspaces when deleting a share server. Now the share server
    deletion skip ipspace removal if the ipspace is one of the
    following: Cluster or Default.

    Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
    Closes-Bug: #1880747
    (cherry picked from commit dbe34c08e2278eb472bc2cbf7f086d6deff7cab2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/743567

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743567
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bf97dcc9d4918ef4ae871ea96886a89a01ac9989
Submitter: Zuul
Branch: stable/train

commit bf97dcc9d4918ef4ae871ea96886a89a01ac9989
Author: Douglas Viroel <email address hidden>
Date: Tue May 26 19:38:56 2020 +0000

    [NetApp] Fix default ipspace deletion issue

    The NetApp driver is fixed to avoid the deletion of cluster
    ipspaces when deleting a share server. Now the share server
    deletion skip ipspace removal if the ipspace is one of the
    following: Cluster or Default.

    Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
    Closes-Bug: #1880747
    (cherry picked from commit dbe34c08e2278eb472bc2cbf7f086d6deff7cab2)
    (cherry picked from commit 2fe7452b1bf8b8975dcd663db3ecce98b5fb499c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/743719

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743719
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=cfdb200e6bd798ce6fd5682567c006b56762ac7c
Submitter: Zuul
Branch: stable/stein

commit cfdb200e6bd798ce6fd5682567c006b56762ac7c
Author: Douglas Viroel <email address hidden>
Date: Tue May 26 19:38:56 2020 +0000

    [NetApp] Fix default ipspace deletion issue

    The NetApp driver is fixed to avoid the deletion of cluster
    ipspaces when deleting a share server. Now the share server
    deletion skip ipspace removal if the ipspace is one of the
    following: Cluster or Default.

    Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
    Closes-Bug: #1880747
    (cherry picked from commit dbe34c08e2278eb472bc2cbf7f086d6deff7cab2)
    (cherry picked from commit 2fe7452b1bf8b8975dcd663db3ecce98b5fb499c)
    (cherry picked from commit bf97dcc9d4918ef4ae871ea96886a89a01ac9989)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/743944

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743944
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=1788cb43142107abb8aa002bdee49961f257523e
Submitter: Zuul
Branch: stable/rocky

commit 1788cb43142107abb8aa002bdee49961f257523e
Author: Douglas Viroel <email address hidden>
Date: Tue May 26 19:38:56 2020 +0000

    [NetApp] Fix default ipspace deletion issue

    The NetApp driver is fixed to avoid the deletion of cluster
    ipspaces when deleting a share server. Now the share server
    deletion skip ipspace removal if the ipspace is one of the
    following: Cluster or Default.

    Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
    Closes-Bug: #1880747
    (cherry picked from commit dbe34c08e2278eb472bc2cbf7f086d6deff7cab2)
    (cherry picked from commit 2fe7452b1bf8b8975dcd663db3ecce98b5fb499c)
    (cherry picked from commit bf97dcc9d4918ef4ae871ea96886a89a01ac9989)
    (cherry picked from commit cfdb200e6bd798ce6fd5682567c006b56762ac7c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/744044

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744044
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0b87677d79be7d44e76c3e939c3ceaca71ee8d27
Submitter: Zuul
Branch: stable/queens

commit 0b87677d79be7d44e76c3e939c3ceaca71ee8d27
Author: Douglas Viroel <email address hidden>
Date: Tue May 26 19:38:56 2020 +0000

    [NetApp] Fix default ipspace deletion issue

    The NetApp driver is fixed to avoid the deletion of cluster
    ipspaces when deleting a share server. Now the share server
    deletion skip ipspace removal if the ipspace is one of the
    following: Cluster or Default.

    Change-Id: I24cda6be69ef9258c6c637be48be32b93d835e0a
    Closes-Bug: #1880747
    (cherry picked from commit dbe34c08e2278eb472bc2cbf7f086d6deff7cab2)
    (cherry picked from commit 2fe7452b1bf8b8975dcd663db3ecce98b5fb499c)
    (cherry picked from commit bf97dcc9d4918ef4ae871ea96886a89a01ac9989)
    (cherry picked from commit cfdb200e6bd798ce6fd5682567c006b56762ac7c)
    (cherry picked from commit 1788cb43142107abb8aa002bdee49961f257523e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila rocky-eol release.