OpenStack Shared File Systems Service (Manila)

Limit formatting routes when adding resources

Bug #1774353 reported by zhongjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
zhongjun
OpenStack Shared File Systems Service (Manila) rocky-3 "R-3"

Bug Description

It is same bug such as cinder.
So in cinder, It is already modified.

link: https://bugs.launchpad.net/cinder/+bug/1307956

becuase of this, "manila metadata function" not working in below situation.

1. manila metadata $(share_id) set Hadoop_TAG_1.2.2=samsung_service
2. manila metadata $(share_id) unset Hadoop_TAG_1.2.2
=> error!! ERROR: Metadata item was not found (HTTP 404)

So It must be modified.

By default, routes.mapper.Mapper.resource adds a bunch of formatted
routes that accept anything after a '.'. Our spec says only .xml
and .json are accepted so limit the formatting to those valuse.

This allows identifiers with a '.' in urls. A few tests were added
to the extensions test to prove that .xml and .json are stripped
but other values are not.

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/571403

Changed in manila:
assignee: nobody → zhongjun (jun-zhongjun)
status: New → In Progress
zhongjun (jun-zhongjun)
description: updated
Tom Barron (tpb)
Changed in manila:
milestone: none → rocky-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-tempest-plugin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/577735

OpenStack Infra (hudson-openstack)
Changed in manila:
assignee: zhongjun (jun-zhongjun) → Goutham Pacha Ravi (gouthamr)
Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Medium
zhongjun (jun-zhongjun)
Changed in manila:
assignee: Goutham Pacha Ravi (gouthamr) → zhongjun (jun-zhongjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/571403
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3c37b942e73937c854b6ffa0e1e15164673ae1f1
Submitter: Zuul
Branch: master

commit 3c37b942e73937c854b6ffa0e1e15164673ae1f1
Author: zhongjun2 <email address hidden>
Date: Thu May 31 16:02:56 2018 +0800

    Limit formatting routes when adding resources

    By default, routes.mapper.Mapper.resource adds a bunch of formatted
    routes that accept anything after a '.'. Our spec says only .xml
    and .json are accepted so limit the formatting to those valuse.

    This allows identifiers with a '.' in urls. A few tests were added
    to the extensions test to prove that .xml and .json are stripped
    but other values are not.

    It is already modified in cinder [1].

    [1] https://bugs.launchpad.net/cinder/+bug/1307956

    Change-Id: I91d8aa967446b5d7ce52f1b245149304494777f3
    Closes-bug: #1774353

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/579272

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/queens)

Reviewed: https://review.openstack.org/579272
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=885762ae98b4a9a794f253ff5e88bb6a98618d4f
Submitter: Zuul
Branch: stable/queens

commit 885762ae98b4a9a794f253ff5e88bb6a98618d4f
Author: zhongjun2 <email address hidden>
Date: Thu May 31 16:02:56 2018 +0800

    Limit formatting routes when adding resources

    By default, routes.mapper.Mapper.resource adds a bunch of formatted
    routes that accept anything after a '.'. Our spec says only .xml
    and .json are accepted so limit the formatting to those valuse.

    This allows identifiers with a '.' in urls. A few tests were added
    to the extensions test to prove that .xml and .json are stripped
    but other values are not.

    It is already modified in cinder [1].

    [1] https://bugs.launchpad.net/cinder/+bug/1307956

    Change-Id: I91d8aa967446b5d7ce52f1b245149304494777f3
    Closes-bug: #1774353
    (cherry picked from commit 3c37b942e73937c854b6ffa0e1e15164673ae1f1)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.2

This issue was fixed in the openstack/manila 6.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 7.0.0.0b3

This issue was fixed in the openstack/manila 7.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-tempest-plugin (master)

Reviewed: https://review.openstack.org/577735
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=ad3b7d4c65ccd694f56436c624dce1bbc84fed43
Submitter: Zuul
Branch: master

commit ad3b7d4c65ccd694f56436c624dce1bbc84fed43
Author: zhongjun2 <email address hidden>
Date: Mon Jun 25 14:23:18 2018 +0800

    Added test for Limit formatting routes when adding resources

    Added test to allows identifiers with a '.' in delete metadata url.
    A few tests were added to the extensions test to prove that .xml and
     .json are stripped.

    Depends-On: https://review.openstack.org/#/c/571403/
    Change-Id: I47b1a48fc07deea086470a71b93d88c8f9232932
    Partial-Bug: #1774353

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.