Limit formatting routes when adding resources like nova api

Bug #1307956 reported by inhye.park
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
inhye.park

Bug Description

It is same bug such as nova in grizzly.
So in grizzly nova, It is already modified.

becuase of this, "cinder metadata function" not working in below situation.

1. cinder metadata $(volume_id) set Hadoop_TAG_1.2.2=samsung_service
2. cinder metadata $(volume_id) unset Hadoop_TAG_1.2.2
=> error!! ERROR: Metadata item was not found (HTTP 404)

So It must be modified.

By default, routes.mapper.Mapper.resource adds a bunch of formatted
routes that accept anything after a '.'. Our spec says only .xml
and .json are accepted so limit the formatting to those valuse.

This allows identifiers with a '.' in urls. A few tests were added
to the extensions test to prove that .xml and .json are stripped
but other values are not.

Mike Perez (thingee)
Changed in cinder:
status: New → Confirmed
importance: Undecided → High
inhye.park (cosmos0703)
Changed in cinder:
assignee: nobody → inhye.park (cosmos0703)
Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
inhye.park (cosmos0703) wrote :

I finished the source as review site's comment.

The site is https://review.openstack.org/#/c/87520/.
I need a code review

Please check and approve.

Revision history for this message
inhye.park (cosmos0703) wrote :

The site is https://review.openstack.org/#/c/87520/.
My bug is stopped in workflow step.

Please check in the workflow.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/87520
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e71d982aa1a21ad7b952fcb8516a9610a5902afb
Submitter: Jenkins
Branch: master

commit e71d982aa1a21ad7b952fcb8516a9610a5902afb
Author: Inhye Park <email address hidden>
Date: Tue Apr 15 18:48:44 2014 +0900

    Limit formatting routes when adding resources

    By default, routes.mapper.Mapper.resource adds a bunch of formatted
    routes that accept anything after a '.'. Our spec says only .xml
    and .json are accepted so limit the formatting to those valuse.

    This allows identifiers with a '.' in urls. A few tests were added
    to the extensions test to prove that .xml and .json are stripped
    but other values are not.

    Closes-bug: #1307956
    Change-Id: I8f0b4ae3b10ea93890f6506662905bd5823412f5

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.