The net, router, and subnet created in the Manila tempest test process are not cleared

[shuaili.wang]

The code version:Newton

Manila related configuration in tempest.conf.
multitenancy_enabled = True
create_networks_when_multitenancy_enabled = True
default_share_type_name = default
image_with_share_tools = manila-service-image-master
image_password = manila
capability_storage_protocol = NFS
capability_snapshot_support = True

When the Manila tempest test creates the share, the net,subnet and router will be created.
But when the tempest test was completed, the created net, subnet, and router were not cleaned up.

For example, Executing tempest test:
manila_tempest_tests.tests.api.admin.test_admin_actions.AdminActionsTest.test_force_delete_share
the tempest-service-xxxxx-network, tempest-service-xxx-subnet and tempest-service-xxxxx-router will be created.
When the test execution ends, net, subnet, and router still exist in the environment

[Tatyana (tdyshka)]

This bug has impact on users running local tests as it basically "fills up" their environment with unused network components and can cause issues re-running the tests.

It seems that there is cleanup built into BaseSharesTest's provide_share_network (lines 417-419) but yet the resources still remain post-test execution.

Attaching examples from:
* Networks
* Subnets
* Routers
* Router ports
* IP address pools
That remain after a few local test runs, using the default Tempest configuration.

[Tom Barron (tpb)]

Marked confirmed because we see lots of tempest-created networks, subnets, routers, ports, etc. left over after successful manila tempest runs with Queens codebase.

[shuaili.wang (shuaili.wang)]

Tom Barron:
Thank you very much for your verification.
I saw someone in the community who mentioned the same bug and submitted the code.
The links are as follows:
https://bugs.launchpad.net/manila/+bug/1754588
https://bugs.launchpad.net/manila/+bug/1755467

[Tom Barron (tpb)]

Shuali, it looks like this bug may be fixed in latest master for manila-tempest-plugin then. Perhaps you can install the latest manila-tempest-plugin and confirm whether your issue is resolved?

[shuaili.wang (shuaili.wang)]

Tom Barron:
I have verified this patch,it can solve the bug I mentioned.

[Tom Barron (tpb)]

Thanks, Shaili!