After run manila tempest network resource do not be cleared

[haobing1]

When use multitenancy_enabled, create net, subnet and router resources be used to create share network, after run the tempest the network resource do not be cleared in the end of tempest.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/552506

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552506
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=264a6029db225716e11fbb5fd7b3014459b869b1
Submitter: Zuul
Branch: master

commit 264a6029db225716e11fbb5fd7b3014459b869b1
Author: haobing1 <email address hidden>
Date: Tue Mar 13 20:39:10 2018 +0800

    After tempest network resource do not be cleared

    When use multitenancy_enabled, mybe create net, subnet and router resources,
    be used to create share network, after run the tempest those network resource
    do not be cleared in the end of tempest.

    Change-Id: I2827485a78ad001eb49b7fc583b15f47662b853a
    Closes-Bug:#1755467

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/572090

[Goutham Pacha Ravi (gouthamr)]

This bug fix broke DHSS=True tests that use tempest's pre-provisioned credentials mechanism [1]. It is currently essential for DHSS=True drivers that test with the NeutronNetworkPlugin (or derivatives) to use pre-provisioned tempest credentials to run tests. You can see the test failures on the container driver jobs (manila-tempest-dsvm-postgres-container) since this change was introduced. When we merged this change, our gate tests were affected by another bug [2] that hid the failures and made us miss it in code review.

I am not currently aware of a better way to fix this problem; but as we explore one, I want to ensure the regression caused by this bug fix [3] is reverted to un-break DHSS=True drivers working with the NeutronNetworkPlugin (or derivatives). Please see the patch reverting [3] proposed as [4]

[1] https://docs.openstack.org/tempest/latest/configuration.html#pre-provisioned-credentials
[2] https://bugs.launchpad.net/manila/+bug/1770183
[3] https://review.openstack.org/#/c/552506/
[4] https://review.openstack.org/#/c/575549/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/575549
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=d1f6a062b696b3c21817386da2c432fc844319e3
Submitter: Zuul
Branch: master

commit d1f6a062b696b3c21817386da2c432fc844319e3
Author: Goutham Pacha Ravi <email address hidden>
Date: Thu Jun 14 21:34:09 2018 +0000

    Revert "After tempest network resource do not be cleared"

    This reverts commit 264a6029db225716e11fbb5fd7b3014459b869b1.
    We use pre-provisioned OpenStack projects (accounts, users and networks)
    to run multi-tenancy tests against the DHSS=True drivers. When using
    the NeutronNetworkPlugin (or its derivatives),
    share servers are not expected to be deleted by the tests. This
    assumption breaks the cleanup committed in 264a6029db225716e11fbb5fd7b3014459b869b1.

    We ought to clean up share servers that get created as part of test runs
    because we clean up all the shares. The default option to teardown
    "unused" share servers [1] currently takes care of freeing up
    share servers after the tests have run.

    If network resources pertain to pre-provisioned
    projects, no cleanup should be done by manila's tempest tests; since
    they are meant to be administered by the test runner (human/automation).

    [1] https://docs.openstack.org/manila/latest/configuration/shared-file-systems/config-options.html

    Related-Bug: #1755467
    Change-Id: I004d88e4e2ccf5a0e1dbaaedc7195f5a8e427559

[shuaili.wang (shuaili.wang)]

Goutham Pacha Ravi:
There is another bug related to this bug.It's all about solving residual problems after Manila tempest
https://bugs.launchpad.net/manila/+bug/1754588
https://review.openstack.org/#/c/551206/，
Will the patch also cause the above problems？
Does the patch still need to be continued?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tom Barron (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/572090
Reason: We reverted the change from which this is a cherry-pick.

[Felipe Rodrigues (felipefutty)]

The problem still is part of tempest code. Is there any plan to work on this improvement ?! Given that nobody is complaining about it, I think that we could consider as not a real problem and close it. What do you think reporter ?! Do you wanna keep it ?!

[Vida Haririan (vhariria)]

This bug has been moved to incomplete due to inactivity. If you do not agree, please update bug status and milestone accordingly.

[Launchpad Janitor (janitor)]

[Expired for OpenStack Shared File Systems Service (Manila) because there has been no activity for 60 days.]