Comment 9 for bug 1631314

Douglas,

> Goutham, I think that the best solution so far is to create a new replica-periodic-update enable/disable command on share replica API. This operation will affect the desired share only.
> In the periodic replica update routine we just need to check if it is enabled before issuing the driver for updating the replica state.
> Now, do you think that this state (enable/disable replica update) will need to be stored in DB? Or can be reset to default(enabled) if the share-manager restarts?

Yes - the toggle-able option to enable/disable needs to be persisted in the database; otherwise the behavior may be non-deterministic: 1) Service HA might interfere with the updates - one share manager might continue to update the replica/s, while another would have such updates disabled 2) Replicas are tenant resources, administrators own the service plane - so it would be hard to justify a ephemeral disable operation since the ones controlling the replica might be unaware of service restarts.

This might need some restructuring of the tests, so that enable/disable actually works as intended. I wouldn't shoot to get this bug fix in Train though - we can try to get the fix up and then evaluate.

At present, I am okay with disabling the tests while we ship the train release.