When attempting to allow_access on a managed share, it fails
because the proper share ID is not retrieved from private storage
prior to attempting to validate that the share exists in the
backend. The same happens when trying to create a share from a
snapshot created from a managed share, the proper share ID is
not retrieved from private storage. While we are dealing with
two possible different IDs it is important to properly display
the API share ID in log messages so it can be matched to the
share instances ID, and not all log messages are accurately doing
so.
This change addresses this by retrieving the ID from
private storage first for update_access and
create_share_from_snapshot operations. The proper unit test changes
included in this patch required a refactor of several IDs to ensure
this problem is addressed in unit tests, thus it made sense to
address several bugs caused by the same problem, having the same fix
and requiring modifications to the same lines of code.
Reviewed: https:/ /review. openstack. org/325874 /git.openstack. org/cgit/ openstack/ manila/ commit/ ?id=5884b3ca3f3 bc4ace14e6991bc a739bec199dd9f
Committed: https:/
Submitter: Jenkins
Branch: stable/mitaka
commit 5884b3ca3f3bc4a ce14e6991bca739 bec199dd9f
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Jun 6 09:41:55 2016 -0300
Fix HDS HNAS errors caused by incorrect IDs
When attempting to allow_access on a managed share, it fails
because the proper share ID is not retrieved from private storage
prior to attempting to validate that the share exists in the
backend. The same happens when trying to create a share from a
snapshot created from a managed share, the proper share ID is
not retrieved from private storage. While we are dealing with
two possible different IDs it is important to properly display
the API share ID in log messages so it can be matched to the
share instances ID, and not all log messages are accurately doing
so.
This change addresses this by retrieving the ID from share_from_ snapshot operations. The proper unit test changes
private storage first for update_access and
create_
included in this patch required a refactor of several IDs to ensure
this problem is addressed in unit tests, thus it made sense to
address several bugs caused by the same problem, having the same fix
and requiring modifications to the same lines of code.
(cherry-picked from commit 081fc4860b7ba3a 87020d2ddae006f 667616fed0) 7e710f57e3c288d 48cd2adf0dd
Closes-bug: #1581541
Closes-bug: #1584179
Closes-bug: #1583785
Change-Id: I8cdb1a8a72a4ac